Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[issue_tracker - raisinbread/tools] Fix issue tracker history wrong module ID #8677

Merged
merged 6 commits into from
Jan 11, 2024
Merged

[issue_tracker - raisinbread/tools] Fix issue tracker history wrong module ID #8677

merged 6 commits into from
Jan 11, 2024

Conversation

zaliqarosli
Copy link
Contributor

@zaliqarosli zaliqarosli commented Apr 25, 2023 •
edited
Loading

Brief summary of changes

This single use tool https://github.com/aces/Loris/blob/main/tools/single_use/Convert_LorisMenuID_to_ModuleID.php failed to convert the now deprecated LorisMenuID to the current modules table ModuleID for rows in issues_history table. The histories now refer to old LorisMenuIDs which map to the wrong module in the new modules table. This PR fixes this discrepancy by providing a patch, fixing the raisinbread dataset , and updating the conversion tool.

How this PR should be used for existing projects:

  • If project upgraded to 23.0 and so already ran the Convert_LorisMenuID_to_ModuleID.php script, the project should run the patch SQL/New_patches/2023-04-25-FixIssueWrongModuleID.sql

  • If the project needs to upgrade to 23.0, the project should run this now fixed single use script Convert_LorisMenuID_to_ModuleID.php

  • Have you updated related documentation?

Testing instructions (if applicable)

Link(s) to related issue(s)

  • Resolves # (Reference the issue this fixes, if any.)

@zaliqarosli zaliqarosli added Caveat for Existing Projects PR contains changes that might impact the code or accepted practices of current active projects Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset labels Apr 25, 2023
@zaliqarosli
Copy link
Contributor Author

zaliqarosli commented Apr 25, 2023 •
edited
Loading

@driusan curious for you to take a look at this.
@CamilleBeau i'm wondering if CCNA has this issue, and whether the patch can be tested on the CCNA data now.
@ridz1208 this will affect the C-BIG upgrade if the Loris uses the issue tracker

@LeighMac @sruthymathew123 @nicolasbrossard wasn't sure who to tag, but wondering if IBIS has this issue too post upgrade

@zaliqarosli zaliqarosli added the 24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 label Jun 15, 2023
@zaliqarosli
Copy link
Contributor Author

zaliqarosli commented Dec 22, 2023 •
edited
Loading

I removed fixes to the tool script tools/single_use/Convert_LorisMenuID_to_ModuleID.php because this PR is going to 24.1-release (we are no longer issuing bugfixes to 23) and so the fixes will never reach the 23.0-release branch needed to run the 22.0 to 23.0 upgrade (the only time the tool script can be run before the LorisMenu table gets deleted).

The SQL patch alone can be run on 24.1 + to sufficiently fix the issues_history modules ID mappings left behind by the single use tool script

@zaliqarosli zaliqarosli added the SQL PR contains SQL modifications such as schema changes and new SQL scripts label Dec 22, 2023
regisoc
regisoc approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@regisoc regisoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Tested:

  • 22 > 23 upgrade + tools/single_use/Convert_LorisMenuID_to_ModuleID.php script > 24 upgrade + this PR patch
  • 24.1-release > make testdata + patch
  • This PR checkout > make testdata

All 3 cases apply the same changes in the issues_history table.

@regisoc regisoc added the Passed Manual Tests PR has undergone proper testing by at least one peer label Dec 22, 2023
@driusan driusan merged commit 32ef64d into aces:24.1-release Jan 11, 2024
9 checks passed
@ridz1208 ridz1208 added this to the 24.1.6 milestone Apr 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@regisoc regisoc regisoc approved these changes

Assignees

@regisoc regisoc

Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Caveat for Existing Projects PR contains changes that might impact the code or accepted practices of current active projects Passed Manual Tests PR has undergone proper testing by at least one peer RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset SQL PR contains SQL modifications such as schema changes and new SQL scripts
Projects
None yet
Milestone
24.1.6
Development

Successfully merging this pull request may close these issues.
4 participants
@zaliqarosli @regisoc @driusan @ridz1208